Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint/MissingSuper #16

Closed
rhunterharris opened this issue Jul 11, 2023 · 1 comment
Closed

Lint/MissingSuper #16

rhunterharris opened this issue Jul 11, 2023 · 1 comment

Comments

@rhunterharris
Copy link
Contributor

Per:
rubocop/rubocop#8506
rubocop/ruby-style-guide#809 (comment)
It's a common practice to disable MissingSuper in certain cases. One of these cases in app/services - we should consider disabling this cop in that directory, since all of our cop disabled are located there (in the monolith).

See discussion: https://sendoso.slack.com/archives/C9L5MARV4/p1689082686897439
@rhunterharris rhunterharris linked a pull request Jul 11, 2023 that will close this issue
[SDQ-2009] lint missing super #17
Closed
@rhunterharris rhunterharris reopened this Jul 13, 2023
@rhunterharris
Copy link
Contributor Author

We have decided to continue enforcing this rule, but whitelist certain classes per-repo

@rhunterharris rhunterharris closed this as not planned Won't fix, can't repro, duplicate, stale Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SDQ-2009] lint missing super sendoso/rubocop-sendoso
1 participant
@rhunterharris