chore: migrate to gh actions #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shwetha-manvinkurke
force-pushed
the
gh-actions
branch
from
d2e7e83
to
32a5d18
Compare
JenniferMah
reviewed
Jan 31, 2022
eshanholtz
approved these changes
Jan 31, 2022
Comment on lines
-5
to
-9
| - version=6 | ||
| - version=8 | ||
| - version=10 | ||
| - version=lts | ||
| - version=latest |
There was a problem hiding this comment.
All of the SendGrid helpers that use make test-docker don't rely on the language version that's installed. They rely on the version env var which is used in their Dockerfile. The GH action needs to set the version env var since right now it will always just use lts:
Lines 1 to 2 in 3251610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.