chore: adjust 'packages/mail/src/mail.d.ts' #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error for callBack function of 'send' and 'sendMultiple' methods is not described as nullable, but it should cause error is null when emails where successfully delivered
JenniferMah
previously approved these changes
Dec 17, 2021
|
|
||
| /** | ||
| * Send multiple emails (shortcut) | ||
| */ | ||
| sendMultiple(data: MailDataRequired, cb?: (error: Error | ResponseError, result: [ClientResponse, {}]) => void): Promise<[ClientResponse, {}]>; | ||
| sendMultiple(data: MailDataRequired, cb?: (error: Error | ResponseError | null, result: [ClientResponse, {}]) => void): Promise<[ClientResponse, {}]>; |
There was a problem hiding this comment.
Hi @collierrgbsitisfise! Thanks for the contribution. Can you add some additional tests to verify that error is null when emails are successfully delivered?
There was a problem hiding this comment.
@JenniferMah done, just added more test cases for mail functionality
JenniferMah
approved these changes
Jan 7, 2022
eshanholtz
added a commit
that referenced
this pull request
Jan 12, 2022
This reverts commit a6a83d1.
eshanholtz
added a commit
that referenced
this pull request
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error for callBack function of 'send' and 'sendMultiple' methods is not
described as nullable, but it should cause error is null when emails
where successfully delivered