Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly specify git tag message #3064

Conversation

sheerlox
Copy link
Member

Fixes #3065.

@travi
Copy link
Member

travi commented Nov 19, 2023

this is a bigger change than it may seem. this changes the resulting tags from lightweight tags to annotated tags. while it could be argued that annotate tags are better for releases, i think that change would be far more than just a bug fix. in addition, enabling annotated tags was attempted previously, but it resulted in problems. i dont have time to track that down right now, but it would be good for one of us to link that previous attempt to this conversation.

i'm not against making this possible at some point in the future, but would want to do it very carefully. if there is a different solution to the referenced problem, i'd prefer a change that isnt quite this impactful

@sheerlox
Copy link
Member Author

I wasn't aware of the difference between annotated and lightweight tags, thanks for pointing out that adding the -m option changes the type of tag being created!

Closing this PR as it's not the right solution (at least without a more thoughtful approach), let's track this in #3065.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hanging forever while tagging the release if git is configured to sign tags
2 participants