Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for errors resulting in a zero exit code #2932

Open
travi opened this issue Aug 30, 2023 · 8 comments · Fixed by Doist/typist#430
Open

Tracking issue for errors resulting in a zero exit code #2932

travi opened this issue Aug 30, 2023 · 8 comments · Fixed by Doist/typist#430

Comments

@travi
Copy link
Member

travi commented Aug 30, 2023

Current behavior

we've received reports of various errors resulting in a zero exit code when they would be expected to exit non-zero. some of these reports are related to the recent conventional-changelog preset breaking changes, but we have some previous reports as well.

i will gather the related issues as a follow up, but want to get this created to start pointing them to

Expected behavior

errors should result in a non-zero exit code so that it is clear when the release process fails

semantic-release version

latest

CI environment

various

Plugins used

No response

semantic-release configuration

n/a

CI logs

n/a

Related reports

@vytautas-pranskunas-
Copy link

watching

@wyardley
Copy link

I not only had it exit 0, but did not see any errors either - the output just stops early
conventional-changelog/conventional-changelog#1109

@dannyadair
Copy link

same here - commits are found, analyzeCommit step started but just exits with 0 not looking at any commits.

Is there a way to pin conventional-changelog to an earlier version?

@wyardley
Copy link

Is there a way to pin conventional-changelog to an earlier version?

An example in the other issue about this:
#2929 (comment) for one way

While semantic-release's suggested workflow is not to use it as a devDependency, we typically have semantic-release and conventional-changelog-conventionalcommits pinned along with our other devdeps and use Renovate to keep it updated, so in that case, we just reverted the changes updating it.

@dannyadair
Copy link

@wyardley Thank you! That worked. We just do an ad-hoc install in a docker container with GitLab CI. Pinning conventional-changelog-conventionalcommits with @6 as per #2929 did the job.

@travi
Copy link
Member Author

travi commented Sep 15, 2023

the latest betas of the commit-analyzer and release-notes-generator plugins have removed the use of promisify for the config loading process, which was the root cause of this for the situation where this was a problem related to #2929. thanks again for the investigation into this in semantic-release/commit-analyzer#525 (comment), @rvagg!

we have seen some other reports of exiting zero when we shouldnt be in other contexts, so i'm going to keep this open for tracking those reports until we can dig deeper into those, but i think the preset related issue is solved once those plugins get promoted

@rvagg
Copy link

rvagg commented Sep 19, 2023

FYI I safely upgraded an initial package today to @semantic-release@v22.0.0, @semantic-release/commit-analyzer@v11.0.0, @conventional-changelog-conventionalcommits@v7.0.2 and @semantic-release/release-notes-generator@v12.0.0 and it appears to have gone through just fine and spat out a release, npm publish and changelog update as expected. No need to hold back conventional-changelog-conventionalcommits to v6 anymore. Thanks!

@tomerh2001
Copy link

#3187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants