fix(log-repo): use the original form of the repo url to remove the need to mask credentials #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
approved these changes
Jun 8, 2022
travi
force-pushed
the
log-repo
branch
3 times, most recently
from
16c6630
to
08c749a
Compare
|
i have been unable to reproduce the test failures locally in either node v16 or v14 |
|
it looks like all of the failures are in |
|
me neither :( Anyone else has any luck? |
…ed to mask credentials fixes #2449
|
🎉 This PR is included in version 19.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
i dont have a great explanation, but i updated the lockfile for #2447 to get it passing and rebased this branch with the mainline after merging that PR to pickup those lockfile changes, which enabled this change to pass the build 🤷🏼 |
morey-tech
pushed a commit
to ratehub/semantic-release
that referenced
this pull request
Sep 12, 2022
…ed to mask credentials (semantic-release#2459) fixes semantic-release#2449
adityahex27
pushed a commit
to hextrust/semantic-release
that referenced
this pull request
Oct 31, 2022
…ed to mask credentials (semantic-release#2459) fixes semantic-release#2449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2449