docs: Correct circleci workflow #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and since node/default executor is already using lts version of cimg/node docker image, the `node/install` step is removed. reference: https://circleci.com/developer/orbs/orb/circleci/node#executors-default
travi
reviewed
Feb 15, 2022
| jobs: | ||
| release: | ||
| executor: node/default | ||
| steps: | ||
| - checkout | ||
| - node/install |
There was a problem hiding this comment.
the reason we include this step is to encourage using the latest lts version of node when releasing, even if that is not the version used to verify the project. does removing this step still accomplish that goal? if not would including a comment make that goal more clear here?
There was a problem hiding this comment.
Thanks for replying!
The reason why that step can be removed is, circleci/node's default executor already uses lts node docker image.
(There is a configurable tag, which defaults to 'lts')
Reference: https://circleci.com/developer/orbs/orb/circleci/node#executors-default
|
🎉 This PR is included in version 19.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
morey-tech
pushed a commit
to ratehub/semantic-release
that referenced
this pull request
Sep 12, 2022
adityahex27
pushed a commit
to hextrust/semantic-release
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when I tried to apply example Circle CI config to my config.yml, I found it contains a YAML syntax error, which is fixed in d2bc910.
And in a2e6ff1, the circleci/node version is upgraded and an unnecessary step is removed.