Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(badge): switched to proper semantic-release logo #2235

Merged
merged 1 commit into from Nov 8, 2021
Merged

Conversation

travi
Copy link
Member

@travi travi commented Nov 8, 2021

shields.io now has our official logo available through simple-icons.

i was trying to get just the logo on the dark part of the left, similar to the previous version, but was unsuccessful without text content on both sections. i dont hate having semantic on the left section and release on the right section, but removing the - steps away from the official name. i'm interested in thoughts around how this is actually rendering.

also, i'm not sure what the history is around the color used for the badge. is it still the most appropriate for the project? i have no reason to change it, but thought this was a good chance to at least confirm.

@travi travi requested a review from a team November 8, 2021 02:10
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏼

@chalkygames123
Copy link
Contributor

@travi @gr2m Hi, I opened #1825 about eight months ago, and I happened to find this PR today :) Could you take a look at it?

And probably we should also update the badge at the top of the README.

@travi
Copy link
Member Author

travi commented Nov 22, 2021

thanks for the ping @chalkygames123! apologies for missing your original post. clearly it is a topic that we find value in. i'll respond in the other issue shortly.

And probably we should also update the badge at the top of the README.

good catch. i obviously overlooked that in my update, but i agree that we should get it up to date. would be happy to accept a contribution to take care of that depending on where we land on the other discussion.

@travi travi mentioned this pull request Nov 22, 2021
@github-actions
Copy link

🎉 This PR is included in version 18.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants