Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic-release push a release to undefined branch #1703

Open
nodece opened this issue Nov 29, 2020 · 1 comment
Open

semantic-release push a release to undefined branch #1703

nodece opened this issue Nov 29, 2020 · 1 comment

Comments

@nodece
Copy link

nodece commented Nov 29, 2020

Current behavior

I guess semantic-release has been updated recently, in my project, semantic-release push a release to undefined branch.

semantic-release should push a release to master branch.

This is my Github Actions: https://github.com/casbin/node-casbin/runs/1469054944.

Expected behavior

semantic-release should push a release to master branch.

Environment

@abbottdev
Copy link

abbottdev commented Dec 23, 2020

I've just had the same issue! - Did some digging...

I think it's related to this change: #1521

It looks like th underlying env-ci library has issues identifying branches semantic-release/env-ci#96 - this is specifically around reporting isPr as being true when running on the master branch it seems.

The first PR correctly implements the bad behaviour in the old one (I think?) Not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants