Use valid git credentials when multiple are provided #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
reviewed
Oct 28, 2020
gr2m
reviewed
Oct 28, 2020
Co-authored-by: Gregor Martynus <39992+gr2m@users.noreply.github.com>
arcln
force-pushed
the
fix-multiple-git-tokens
branch
from
2dffc91
to
0ec1718
Compare
|
Fixed the typo and conflicts, ready to merge! |
|
🎉 This PR is included in version 17.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 10, 2021
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1668 for details about the issue. Here I will discuss about the fix implementation.
If the given URL works out of the box or if a single token is available in the environment, the behaviour remains unchanged.
However if there is multiple tokens available, it will perform a
git.verifyAuthcall for each of them, and return the first of them that is working.If none of them are working, it will return the URL as is.
This behaviour is tested in
integration.test.js. It isn't tested inget-git-auth-url.test.jsbecause I need gitbox functionalities to test it.