New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Throw an Error if package.json has duplicate "repository" key #1656
feat: Throw an Error if package.json has duplicate "repository" key #1656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one typo, but otherwise looks great 👍🏼
where's the typo? |
looks like you found my comment. surprised that it didnt show up in this thread. must be because i still approved 🤷🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
🎉 This PR is included in version 17.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
i reverted this change for now in order to give us time to understand #1657 |
addresses bad DX reported in #1655 /cc @kentcdodds @travi