fix: use NPM_CONFIG_USERCONFIG in get-registry to match auth
#362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
reviewed
Apr 29, 2021
rodoabad
approved these changes
May 2, 2021
gr2m
approved these changes
May 2, 2021
There was a problem hiding this comment.
I confirmed locally that the test fails without the fix. Thanks for the PR @jameshartig 👍🏼
gr2m
changed the title
NPM_CONFIG_USERCONFIG in get-registry to match auth
gr2m
requested changes
May 2, 2021
There was a problem hiding this comment.
oh sorry, one more thing, I think we should document the env variable in https://github.com/semantic-release/npm#environment-variables?
Previously NPM_CONFIG_USERCONFIG was only used for getting the auth token and not used for actually getting the registry from .npmrc. Fixes semantic-release#349
|
@gr2m good call! I updated the README |
gr2m
approved these changes
May 4, 2021
|
🎉 This PR is included in version 7.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously NPM_CONFIG_USERCONFIG was only used for getting the auth token and not used for actually getting the registry from .npmrc.
Fixes #349