Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve error message text for npm tokens #323

Merged
merged 2 commits into from
Jan 17, 2021
Merged

fix: improve error message text for npm tokens #323

merged 2 commits into from
Jan 17, 2021

Conversation

domoritz
Copy link
Contributor

fixes #322

@domoritz
Copy link
Contributor Author

I am still a bit confused by the wording. The docs at https://docs.npmjs.com/about-two-factor-authentication use different words than the actual page in the account settings. Let me know whether I got something wrong.

Screen Shot 2021-01-17 at 11 07 13

@domoritz domoritz mentioned this pull request Jan 17, 2021
Closed
gr2m
gr2m approved these changes Jan 17, 2021
View reviewed changes
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, thank you!

@gr2m gr2m merged commit 88e5862 into semantic-release:master Jan 17, 2021
@github-actions
Copy link

🎉 This PR is included in version 7.0.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken sentence in error message
2 participants
@domoritz @gr2m