Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump conventional commits parser to version 3.2.3 #289

Merged
merged 1 commit into from Nov 23, 2021

Conversation

AlexanderBabel
Copy link
Contributor

This PR fixes #224 as mentioned in #225.

Additionally, it fixes CVE-2021-23425 which was fixed in Version 3.2.2 of the conventional-commits-parser.

@AlexanderBabel AlexanderBabel changed the title chore: bump conventional commits parser to version 3.2.3 fix: bump conventional commits parser to version 3.2.3 Nov 23, 2021
Copy link
Member

@travi travi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@AlexanderBabel
Copy link
Contributor Author

Thanks for the fast approval. Do you know why it failed the first time? Are there some caching or connectivity issues in the pipeline?

@travi
Copy link
Member

travi commented Nov 23, 2021

Do you know why it failed the first time? Are there some caching or connectivity issues in the pipeline?

not entirely sure, but we do see the cb() was never called error that showed up occasionally. as much as i would prefer to eliminate flakey issues like that one, i'm unsure what to do for that one other than to try again. almost always works with the retry 🤷🏼

@travi travi merged commit fc0a88a into semantic-release:master Nov 23, 2021
@github-actions
Copy link

🎉 This PR is included in version 9.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commit analyzer fails if there are commits without proper header
2 participants