Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GooglePlusBot is not identified as a bot #125

Open
sangaline opened this issue Feb 28, 2023 · 2 comments
Open

GooglePlusBot is not identified as a bot #125

sangaline opened this issue Feb 28, 2023 · 2 comments

Comments

@sangaline
Copy link

GooglePlusBot was originally used to generate link previews on Google Plus, but is now used for other use-cases like generating previews for links in SMS messages on Android (see fnando/browser#515 for additional context). The library doesn't tag this as a bot despite it being one.

Here's an example of the user agent processing:

from user_agents import parse

ua_string = 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 Google-PageRenderer Google (+https://developers.google.com/+/web/snippet/)'
user_agent = parse(ua_string)
print('Browser?', user_agent.get_browser())
print('Is Bot?', user_agent.is_bot)
Browser? GooglePlusBot
Is Bot? False
@sangaline
Copy link
Author

This seems like a special case of #35, there isn't really much logic around the bot detection.

@PetrDlouhy
Copy link

The logic is in uap-core. Shouldn't the problem be reported there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants