Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colorama refactoring for Windows users #2164

Closed
mdmintz opened this issue Oct 6, 2023 · 1 comment · Fixed by #2166
Closed

Colorama refactoring for Windows users #2164

mdmintz opened this issue Oct 6, 2023 · 1 comment · Fixed by #2166
Assignees
@mdmintz
Labels
enhancement Making things better

Comments

@mdmintz
Copy link
Member

mdmintz commented Oct 6, 2023

Colorama refactoring for Windows users

Windows users may experience performance degradation if colorama.init(autoreset=True) gets called multiple times.

To get around this, SeleniumBase should instead call colorama.just_fix_windows_console() (Added in tartley/colorama#352).

colorama.init(autoreset=True) is currently used in multiple places in SeleniumBase. (This is OK for macOS and Linux users!)

This refactoring will prevent issues, such as #2163
@mdmintz mdmintz added the enhancement Making things better label Oct 6, 2023
@mdmintz mdmintz self-assigned this Oct 6, 2023
@mdmintz mdmintz mentioned this issue Oct 6, 2023
Merged
@mdmintz
Copy link
Member Author

mdmintz commented Oct 6, 2023

This was resolved in 4.19.2 - https://github.com/seleniumbase/SeleniumBase/releases/tag/v4.19.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdmintz mdmintz

Labels
enhancement Making things better
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Colorama, update graphics library, and add raw driver methods seleniumbase/SeleniumBase
1 participant
@mdmintz