-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cachelookup annotation support #1894
add cachelookup annotation support #1894
Conversation
1d0d7f5
to
3a13663
Compare
Hi @groov1kk ! I have only two concerns:
|
3a13663
to
347d1a0
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Hello
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a very well done PR to me.
Thumbs up! @groov1kk
…- it's used by `selenide-appium`.
Proposed changes
Added support of @CachedLookup selenium annotation for page objects:
Checklist
gradlew check chrome_headless firefox_headless
command