Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot deselect items in grouped multiple select when data ids are not strings #3882

Closed
Jivings opened this issue Oct 29, 2015 · 5 comments · May be fixed by #6239
Closed

Cannot deselect items in grouped multiple select when data ids are not strings #3882

Jivings opened this issue Oct 29, 2015 · 5 comments · May be fixed by #6239
Labels
4.x confirmed bug status: stale

Comments

@Jivings
Copy link

Jivings commented Oct 29, 2015

On a multi-select, if the ID's of data items are a number, then it is impossible to deselect. I believe this is the offending code in which the id is represented internally as a string, but a number in data.id.
@Jivings
Copy link
Author

Jivings commented Oct 29, 2015

Demo here. Narrowed the issue down to only multiple selects which are grouped.

Jivings pushed a commit to Jivings/select2 that referenced this issue Oct 29, 2015
Fixes select2#3882 - cannot deselect items in grouped multiple select…
065a33f 
… when data ids are not strings
@Jivings Jivings mentioned this issue Oct 29, 2015
Closed
@Jivings
Copy link
Author

Jivings commented Oct 29, 2015

Fixed by making sure the comparison is always done on strings.

@Jivings Jivings changed the title Cannot deselect items when data ids are numbers Cannot deselect items in grouped multiple select when data ids are not strings Oct 29, 2015
@stale
Copy link

stale bot commented Mar 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale label Mar 13, 2019
@Jivings
Copy link
Author

Jivings commented Mar 15, 2019

Still an issue.

@stale stale bot removed the status: stale label Mar 15, 2019
@stale
Copy link

stale bot commented May 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale label May 14, 2019
@stale stale bot closed this as completed May 22, 2019
@jayaddison jayaddison mentioned this issue Mar 9, 2023
Merged
@jayaddison jayaddison mentioned this issue Mar 30, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.x confirmed bug status: stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixup: convert optgroup child data identifiers to string datatype openculinary/select2
2 participants
@Jivings @kevin-brown