Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up arrow error when there is no options #5127

Closed
wants to merge 1 commit into from
Closed

Fix up arrow error when there is no options #5127

wants to merge 1 commit into from

Conversation

raapperez
Copy link
Contributor

This pull request includes a

  • Bug fix
  • New feature
  • Translation

The following changes were made

  • Select2 throws an error when user presses up arrow key and there is no options. I saw that in this case currentIndex in results.js is -1. So I just changed the function exit condition.
  • This error is in select2 since 2015 and is causing more than 1k errors per week in our logs. If this is not the correct fix. Please fix it.

#3523

@alexweissman alexweissman added this to the 4.0.6 milestone Nov 19, 2017
@alexweissman
Copy link
Contributor

This error is in select2 since 2015 and is causing more than 1k errors per week in our logs. If this is not the correct fix. Please fix it.

There is no central full-time organization responsible for developing Select2. Everyone contributes their free time when they can. Thank you for finding and fixing this bug, but please do not dictate demands.

@alexweissman
Copy link
Contributor

Will be released in 4.0.6-rc.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants