Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update select2.js #5089

Closed
wants to merge 1 commit into from
Closed

Update select2.js #5089

wants to merge 1 commit into from

Conversation

kutec
Copy link

@kutec kutec commented Oct 24, 2017

Adding ending statement at the start of the code as absence of that causes console error while concatenating files.

This pull request includes a

  • Bug fix

The following changes were made

  • Added semi column at the starting of the code to avoid concatenation issue with Grunt

If this is related to an existing ticket, include a link to it as well. - NO

Adding ending statement at the start of the code as absence of that causes console error while concatenating files.
@alexweissman alexweissman added this to the 4.0.6 milestone Oct 25, 2017
@alexweissman
Copy link
Contributor

Just FYI, this change needs to be made in src/, not in dist/. Please review https://github.com/select2/select2/blob/master/.github/CONTRIBUTING.md#contributing-to-select2 to see how Select2 is built - thanks!

alexweissman added a commit that referenced this pull request Oct 26, 2017
Adding ending statement at the start of the code as absence of that causes console error while concatenating files.
@alexweissman
Copy link
Contributor

Merged into develop for 4.0.6 release.

@kutec
Copy link
Author

kutec commented Oct 27, 2017

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants