Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better translation for french language #4988

Closed
Nhooxy opened this issue Jul 12, 2017 · 2 comments
Closed

Better translation for french language #4988

Nhooxy opened this issue Jul 12, 2017 · 2 comments
Labels
feature: translation/i18n
Milestone
4.0.5

Comments

@Nhooxy
Copy link

Nhooxy commented Jul 12, 2017

In file select2/src/js/select2/i18n/fr.js
This is a better translation :
var message = 'Saisissez au moins ' + remainingChars + ' caractère';
@foxalfabravo
Copy link

foxalfabravo commented Jul 12, 2017 •
edited

var message = 'Saisissez au moins ' + remainingChars + ' caractère' + (remainingChars>1)?'s':'';

alexweissman added a commit that referenced this issue Sep 25, 2017
@alexweissman
Fixes French translation (see #4988)
ed24c34
@alexweissman alexweissman added this to the 4.0.5 milestone Sep 27, 2017
@alexweissman
Copy link
Contributor

Fixed in v4.0.5 (ed24c34). Sorry we couldn't merge your commit in directly for attribution - there were too many conflicts so we had to use a recursive merge.

@alexweissman alexweissman mentioned this issue Nov 10, 2017
Closed
@ragusa87 ragusa87 mentioned this issue Jan 9, 2018
Closed
vedanshujain pushed a commit to woocommerce/selectWoo that referenced this issue Jun 21, 2018
@alexweissman @vedanshujain
Fixes French translation (see select2#4988)
cb7de47
vedanshujain pushed a commit to woocommerce/selectWoo that referenced this issue Jun 21, 2018
@alexweissman @vedanshujain
Fixes French translation (see select2#4988)
8289644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature: translation/i18n
Projects
None yet
Milestone
4.0.5
Development

No branches or pull requests
3 participants
@alexweissman @foxalfabravo @Nhooxy