Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix titles not being cleared (#3895) #4640

Closed
wants to merge 3 commits into from
Closed

Fix titles not being cleared (#3895) #4640

wants to merge 3 commits into from

Conversation

timothykang
Copy link
Contributor

@timothykang timothykang commented Oct 17, 2016

This pull request includes a

  • Bug fix

The following changes were made

  • Remove title attribute on selection clear
  • Added test assertions

Fixes #3895.

@alexweissman alexweissman added this to the 4.0.6 milestone Oct 26, 2017
alexweissman pushed a commit that referenced this pull request Oct 26, 2017
…4640)

See #3895, and jQuery docs on `attr`:

> As of jQuery 1.6, the .prop() method provides a way to explicitly retrieve property values, while .attr() retrieves attributes.
@alexweissman
Copy link
Contributor

Merged into develop for 4.0.6 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants