Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta 8 is not usable with rails-assets anymore #48

Open
fsauter opened this issue Jul 6, 2016 · 2 comments
Open

Beta 8 is not usable with rails-assets anymore #48

fsauter opened this issue Jul 6, 2016 · 2 comments

Comments

@fsauter
Copy link

fsauter commented Jul 6, 2016

Hi all,

since beta8 I can't use this repo with rails-assets anymore (problem relates to the following commit: 494123d)

Rails assets uses bower's main property to decide which files it bundles.. in result of the mentioned commit I don't have the compiled files available anymore. You might want to consider to add the dist files to bower main property again? So long I will use beta7.

image

Cheers Florian

@fsauter fsauter changed the title Not usable with rails-assets Beta 8 is not usable with rails-assets anymore Jul 6, 2016
@fk
Copy link
Member

fk commented Aug 3, 2016

Hey @fsauter!

Reading in the bower.json specs, main can contain "one file per filetype" – which sounds like your problem is easily solved by adding back select2-bootstrap.css (or its minified version) to bower.json.

Instead of going the trial-and-error route and rushing another release, I would like to ask @kalidema (who suggested the change that resulted in the problem you are having) and @kevin-brown (who handles all the hard work over at Select2 and probably knows why Select2s bower.json does not contain any compiled CSS) for advice, first.

For now, allow me one question: How do things work for you in terms of Select2, its bower.json and rails-assets?

@kevin-brown
Copy link
Member

There's a relevant rails-assets ticket to all of this: tenex/rails-assets#367

@kevin-brown (who handles all the hard work over at Select2 and probably knows why Select2s bower.json does not contain any compiled CSS) for advice, first.

The answer for why we do it lies in the following pull request: select2/select2#3350

In short: There is/was a change to the Bower spec, and now they prefer the original source files over the pre-built distribution files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants