Skip to content

Added HighWaterMark to Message #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Conversation

scarbo87
Copy link
Contributor

@scarbo87 scarbo87 commented Nov 4, 2019

Sometimes I need read HighWaterMark while reading messages.

#373

@achille-roussel
Copy link
Contributor

Am I right that this change also includes #359 ?

@leeson1995
Copy link

If there is no problem, please merge quickly~ @scarbo87 @achille-roussel

@achille-roussel
Copy link
Contributor

Hello @scarbo87, going through the backlog here. Do you still need this PR merged or did you find a workaround?

@scarbo87
Copy link
Contributor Author

Hello @achille-roussel, I've just refreshed my PR. If you can merge this it will be great :)

Copy link
Contributor

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

pull bot pushed a commit to rizalgowandy/kafka-go that referenced this pull request Mar 12, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ghost
Copy link

ghost commented Mar 16, 2021

Curious, how long until this should get released? Would like to track how far behind our consumer is for tuning.

@achille-roussel achille-roussel merged commit 1bf085c into segmentio:master Mar 16, 2021
@achille-roussel
Copy link
Contributor

Thanks for the ping @jdeal-mediamath, this is released in v0.4.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants