Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong location for G109 #829

Merged
merged 1 commit into from Jul 6, 2022
Merged

Fix wrong location for G109 #829

merged 1 commit into from Jul 6, 2022

Conversation

yunwei37
Copy link
Contributor

@yunwei37 yunwei37 commented Jul 2, 2022

Fix #742 : G109 tells the location at strconv.Atoi instead of strconv.Atoi result conversion to int16/32.

Before this commit, G109 will report on strconv.Atoi.
After this, it will report on the convertion likeint32(a).

Before this commit, G109 will report on `strconv.Atoi`.
After this, it will report on the convertion like`int32(a)`.
@codecov-commenter
Copy link

Codecov Report

Merging #829 (3365f4a) into master (b0f3e78) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #829   +/-   ##
=======================================
  Coverage   74.35%   74.35%           
=======================================
  Files          50       50           
  Lines        3124     3124           
=======================================
  Hits         2323     2323           
  Misses        735      735           
  Partials       66       66           
Impacted Files Coverage Δ
rules/integer_overflow.go 93.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f3e78...3365f4a. Read the comment docs.

@ccojocar ccojocar merged commit 602ced7 into securego:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

G109 tells the location at strconv.Atoi instead of strconv.Atoi result conversion to int16/32
3 participants