Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix #736.
Root cause
Block comments will have an extra whitespace before the comment content that gotten from
group.Text()
. In the following table,▯
indicates to a whitespace.group.Text()
// #nosec
/* #nosec */
#nosec
▯#nosec
In PR #735,
#nosec
or othernoSecAlternativeTag
is treated as a prefix of the annotation. There was not a test case that covered block comments and resulted in #736.Solution in this PR
Remove the whitespaces before comments with
strings.Trim()
.