add openssh to docker image #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaffee How much does the image size increases when adding openssh? |
Codecov Report
@@ Coverage Diff @@
## master #719 +/- ##
=======================================
Coverage 69.60% 69.60%
=======================================
Files 47 47
Lines 2859 2859
=======================================
Hits 1990 1990
Misses 813 813
Partials 56 56 Continue to review full report at Codecov.
|
|
@ccojocar if I'm doing this right ( |
I'm trying to scan a project which has dependencies which are private projects. When Go tries to fetch the dependencies it normally uses HTTPS, but that doesn't work if they're private (terminal prompts disabled, can't enter username/password). So you do this little trick with git configuration to get Go to fetch dependencies over ssh: `GIT_CONFIG_PARAMETERS=url.ssh://git@github.com/.insteadOf=https://github.com/` unfortunately the docker image doesn't have ssh installed so this doesn't work :)
|
just rebased on master, but image size didn't change |
|
@jaffee Thanks for clarification. It looks good to me. I'll merge it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to scan a project which has dependencies which are private projects. When Go tries to fetch the dependencies it normally uses HTTPS, but that doesn't work if they're private (terminal prompts disabled, can't enter username/password). So you do this little trick with git configuration to get Go to fetch dependencies over ssh:
GIT_CONFIG_PARAMETERS=url.ssh://git@github.com/.insteadOf=https://github.com/unfortunately the docker image doesn't have ssh installed so this doesn't work :)