Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #644 #645

Merged
merged 1 commit into from Jun 13, 2021
Merged

Fixes #644 #645

merged 1 commit into from Jun 13, 2021

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Jun 4, 2021

Hi @wongherlung , @ShreyasSubhedar would you mind checking this fix ?

@codecov-commenter
Copy link

Codecov Report

Merging #645 (50c912f) into master (e3dffd6) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #645      +/-   ##
==========================================
+ Coverage   71.82%   71.86%   +0.03%     
==========================================
  Files          44       44              
  Lines        1803     1802       -1     
==========================================
  Hits         1295     1295              
+ Misses        461      460       -1     
  Partials       47       47              
Impacted Files Coverage Δ
cmd/gosec/main.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3dffd6...50c912f. Read the comment docs.

@wongherlung
Copy link
Contributor

LGTM! Thank you for the fix.

@ShreyasSubhedar
Copy link
Contributor

good catch

@ccojocar ccojocar merged commit 3ff0a2c into securego:master Jun 13, 2021
@mmorel-35 mmorel-35 deleted the issue-644 branch June 13, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants