Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export a method to decode Envelope payload using flexible base64 decoder #17

Merged
merged 2 commits into from May 30, 2022
Merged

Export a method to decode Envelope payload using flexible base64 decoder #17

merged 2 commits into from May 30, 2022

Conversation

ethan-lowman-dd
Copy link
Contributor

@ethan-lowman-dd ethan-lowman-dd commented Apr 8, 2022 •
edited

Since b64Decode is not exported, there's no way to easily decode the envelope to spec using the flexible base64 decoder. This PR adds a function on Envelope which returns the decoded payload.

An alternate name for the method might be SerializedBody, which matches the spec closer.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2118067173

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-94.0%) to 0.0%
Totals Coverage Status
Change from base Build 1970892819: -94.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 11, 2022 •
edited

Pull Request Test Coverage Report for Build 2156580681

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 94.068%
Totals Coverage Status
Change from base Build 1970892819: 0.08%
Covered Lines: 222
Relevant Lines: 236
💛 - Coveralls

adityasaky
adityasaky approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@adityasaky adityasaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @shibumi do you want to verify?

dsse/sign.go Outdated Show resolved Hide resolved
@adityasaky adityasaky merged commit edec85b into secure-systems-lab:main May 30, 2022
@adityasaky
Copy link
Member

Apologies for the delay, this fell off my radar. Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityasaky adityasaky Awaiting requested review from adityasaky

@shibumi shibumi Awaiting requested review from shibumi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ethan-lowman-dd @coveralls @adityasaky