Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize sizing and size modifier values for form controls #596

Closed
sebnitu opened this issue May 25, 2021 · 1 comment
Closed

Standardize sizing and size modifier values for form controls #596

sebnitu opened this issue May 25, 2021 · 1 comment
Labels

Comments

@sebnitu
Copy link
Owner

sebnitu commented May 25, 2021

Problem

Vrembem has a number of form controls setup as their own components. For composability, they share similar styling patterns, one of which is their sizing. To help maintain these styles more consistently, we should look into creating core variables for handling form-control styles which would be inherited by the following components:

  • button
  • input
  • checkbox
  • radio
  • switch

A size variable example would be:

$form-control-size: 2.5rem !default; // 40px
$form-control-size-sm: 1.875rem !default; // 30px
$form-control-size-lg: 3.125rem !default; // 50px

It would also be nice to include size modifiers for checkbox, radio and switch components. Lastly, there should be a way to incorporate text as a form control (such as labels) that would inherit similar sizing patterns.

@sebnitu
Copy link
Owner Author

sebnitu commented May 27, 2021

This feature was added in #599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant