Fix GlobalState collection to ignore the Composer proxy #4846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianbergmann
added
feature/process-isolation
jrfnl
added a commit
to jrfnl/BrainMonkey
that referenced
this pull request
Dec 29, 2021
Both Composer, as well as PHPUnit have released new versions to try and fix the issue with tests being run with process isolation, which were resulting in the following error: ``` PHPUnit\Framework\Exception: PHP Fatal error: strict_types declaration must be the very first statement in the script in /home/runner/work/BrainMonkey/BrainMonkey/vendor/phpunit/phpunit/phpunit on line 2 ``` While that fixes the builds for runs against the `highest` versions of dependencies, it still does not solve the problem when running the tests with the `lowest` dependencies. Build against the `lowest` dependencies now hang indefinitely. This commit attempts to fix this by using Composer 2.1 for builds against `lowest` dependencies. It also sets a 15 minute time-out for the test runs against the `lowest` dependencies to prevent builds being very slow in reporting. Refs: * composer/composer#10387 * sebastianbergmann/phpunit#4846 * https://github.com/composer/composer/releases/tag/2.2.2 * https://github.com/sebastianbergmann/phpunit/blob/9.5/ChangeLog-9.5.md#9511---2021-12-25
jrfnl
added a commit
to Brain-WP/BrainMonkey
that referenced
this pull request
Dec 29, 2021
Both Composer, as well as PHPUnit have released new versions to try and fix the issue with tests being run with process isolation in combination with installation via Composer 2.2, which were resulting in the following error: ``` PHPUnit\Framework\Exception: PHP Fatal error: strict_types declaration must be the very first statement in the script in /home/runner/work/BrainMonkey/BrainMonkey/vendor/phpunit/phpunit/phpunit on line 2 ``` While that fixes the builds for runs against the `highest` versions of dependencies, it still does not solve the problem when running the tests with the `lowest` dependencies (or against PHP 5.6). Those builds now hang indefinitely. This commit attempts to fix this by using Composer 2.1 for builds against `lowest` dependencies and against PHP 5.6. It also sets a 15 minute time-out for the test runs against the `lowest` dependencies to prevent builds being very slow in reporting. Refs: * composer/composer#10387 * sebastianbergmann/phpunit#4846 * https://github.com/composer/composer/releases/tag/2.2.2 * https://github.com/sebastianbergmann/phpunit/blob/9.5/ChangeLog-9.5.md#9511---2021-12-25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes composer/composer#10387
Composer 2.2 introduces some additional indirection for binaries to allow everyone to use custom PHP versions e.g.
php7.4 vendor/bin/phpunitand ensure thatvendor/phpunit/phpunit/phpunitis executed with php7.4 always (this previously worked only in cases/platforms where symlinks were supported).Ideally this would be fixed in older PHPUnit versions too if possible.. The patch applies down to PHPUnit 4.x as far as I can tell.
I can workaround it to some extent in Composer using the global var
__PHPUNIT_ISOLATION_BLACKLIST/__PHPUNIT_ISOLATION_EXCLUDE_LISTto mark the included (vendor/phpunit/phpunit/phpunit) file excluded but that is only going to fix it for PHPUnit 6+, and I am not sure how reliable that is going to be in the wild if third party code blindly overwrites the global instead of merging their values into it.