Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Cobertura XML report format #4462

Closed
wants to merge 2 commits into from

Conversation

smmccabe
Copy link
Contributor

Cobertura options to for once sebastianbergmann/php-code-coverage#812 gets merged in.

There is 1 type check failing that I don't understand. It references a method that hasn't been changed with this patch so I am unclear as to why it is failing now and doesn't on master. I haven't used psalm before though so maybe I am just missing something.

@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #4462 into master will decrease coverage by 0.12%.
The diff coverage is 57.40%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4462      +/-   ##
============================================
- Coverage     85.26%   85.14%   -0.13%     
- Complexity     4514     4532      +18     
============================================
  Files           243      245       +2     
  Lines         12372    12424      +52     
============================================
+ Hits          10549    10578      +29     
- Misses         1823     1846      +23     
Impacted Files Coverage Δ Complexity Δ
src/TextUI/Help.php 100.00% <ø> (ø) 23.00 <0.00> (ø)
...UI/XmlConfiguration/Migration/MigrationBuilder.php 75.00% <ø> (ø) 5.00 <0.00> (ø)
src/TextUI/TestRunner.php 65.68% <16.66%> (-0.99%) 224.00 <0.00> (+5.00) ⬇️
...Migration/Migrations/CoverageCoberturaToReport.php 33.33% <33.33%> (ø) 2.00 <2.00> (?)
src/TextUI/CliArguments/Builder.php 79.05% <50.00%> (-0.28%) 120.00 <0.00> (+1.00) ⬇️
src/TextUI/CliArguments/Configuration.php 67.47% <50.00%> (-0.29%) 266.00 <4.00> (+3.00) ⬇️
src/TextUI/CliArguments/Mapper.php 78.04% <50.00%> (-0.35%) 81.00 <0.00> (+1.00) ⬇️
...tUI/XmlConfiguration/CodeCoverage/CodeCoverage.php 81.05% <77.77%> (-0.56%) 36.00 <4.00> (+3.00) ⬇️
...XmlConfiguration/CodeCoverage/Report/Cobertura.php 100.00% <100.00%> (ø) 2.00 <2.00> (?)
src/TextUI/XmlConfiguration/Loader.php 97.48% <100.00%> (+0.03%) 135.00 <0.00> (+1.00)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc60ae...29d51ae. Read the comment docs.

@smmccabe
Copy link
Contributor Author

Figured out the type checker issue, fixed.

@sebastianbergmann sebastianbergmann changed the title Add cobertura format Support for Cobertura XML report format Sep 26, 2020
@sebastianbergmann sebastianbergmann added this to the PHPUnit 9.4 milestone Sep 26, 2020
@sebastianbergmann sebastianbergmann added feature/code-coverage Issues related to code coverage (but not php-code-coverage) feature/test-runner CLI test runner type/enhancement A new idea that should be implemented labels Sep 26, 2020
@sebastianbergmann sebastianbergmann self-assigned this Sep 26, 2020
@DanielBadura
Copy link

Oh wow nice! Just discovered a new feature in GitLab that needs the cobertura report (https://about.gitlab.com/releases/2020/09/22/gitlab-13-4-released/#inline-code-coverage-remarks-inside-mr-diffs).

Gonna try this out the next days 😈
Thanks alot!

@Xplouder
Copy link

@DanielBadura did you try this feature?

@sebastianbergmann Looks like you closed this PR. Any special reason to not include this feature? Thank you.

@DanielBadura
Copy link

Yeah it tried to try it :D
Couldnt get it really to work with GitLab. I didnt had much time toinvestigate it any further.

its not just closed, the feature is in phpunit ;o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/code-coverage Issues related to code coverage (but not php-code-coverage) feature/test-runner CLI test runner type/enhancement A new idea that should be implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants