Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast exception message to string #3788

Merged
merged 1 commit into from Aug 7, 2019
Merged

Cast exception message to string #3788

merged 1 commit into from Aug 7, 2019

Conversation

jderusse
Copy link
Contributor

@jderusse jderusse commented Aug 7, 2019

Since PHPUnit 8, the PHPUnit\Framework\Constraint\ExceptionMessage contains a strict_types=1 annotation.
This triggers an TypeError when exception's message is not a string, but a class with a __toString method like symfony/symfony does in AutowiringFailedException.

This PR cast the exception message to string

@sebastianbergmann sebastianbergmann merged commit 052b0d3 into sebastianbergmann:8.3 Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jderusse @nicolas-grekas @sebastianbergmann