From 3fbc317e4f7796daddbd364f53b992675640c889 Mon Sep 17 00:00:00 2001 From: Ewout Pieter den Ouden Date: Thu, 7 Feb 2019 16:58:28 +0100 Subject: [PATCH 1/2] Make sure random seed is also shown when not running --verbose --- ...r-randomized-seed-with-dependency-resolution.phpt | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/tests/end-to-end/test-order-randomized-seed-with-dependency-resolution.phpt b/tests/end-to-end/test-order-randomized-seed-with-dependency-resolution.phpt index fceab037133..c18642229d7 100644 --- a/tests/end-to-end/test-order-randomized-seed-with-dependency-resolution.phpt +++ b/tests/end-to-end/test-order-randomized-seed-with-dependency-resolution.phpt @@ -4,12 +4,11 @@ phpunit --random-order --random-order-seed=54321 --resolve-dependencies ../_file Date: Thu, 7 Feb 2019 16:59:01 +0100 Subject: [PATCH 2/2] Always print random seed in test result header --- src/TextUI/TestRunner.php | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/TextUI/TestRunner.php b/src/TextUI/TestRunner.php index 7c1a595ede8..4c7d77fc2b8 100644 --- a/src/TextUI/TestRunner.php +++ b/src/TextUI/TestRunner.php @@ -338,13 +338,6 @@ public function doRun(Test $suite, array $arguments = [], bool $exit = true): Te $this->writeMessage('Runtime', $runtime); - if ($arguments['executionOrder'] === TestSuiteSorter::ORDER_RANDOMIZED) { - $this->writeMessage( - 'Random seed', - $arguments['randomOrderSeed'] - ); - } - if (isset($arguments['configuration'])) { $this->writeMessage( 'Configuration', @@ -367,6 +360,13 @@ public function doRun(Test $suite, array $arguments = [], bool $exit = true): Te } } + if ($arguments['executionOrder'] === TestSuiteSorter::ORDER_RANDOMIZED) { + $this->writeMessage( + 'Random seed', + $arguments['randomOrderSeed'] + ); + } + if (isset($tooFewColumnsRequested)) { $this->writeMessage('Error', 'Less than 16 columns requested, number of columns set to 16'); }