New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestDox colorization #3439
TestDox colorization #3439
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3439 +/- ##
============================================
+ Coverage 82.15% 82.57% +0.41%
- Complexity 3580 3604 +24
============================================
Files 143 144 +1
Lines 9398 9405 +7
============================================
+ Hits 7721 7766 +45
+ Misses 1677 1639 -38
Continue to review full report at Codecov.
|
Wow! :-) |
Please change the target from |
No problem, will rebase on |
@sebastianbergmann I have rebased it on The ongoing small improvements can go in a future pull request together with other housekeeping. I have a small list of nice-to-haves. Let me know if you have any requests. :) |
@sebastianbergmann I think I'm done with this (for now ;-) and get working on the general event/listener improvements. |
Switched to ANSI 8-color magenta for 'slow tests' for now. Will redesign this part of the result report later on
🎄 🎁 @sebastianbergmann I'm going to continue my test suite related housekeeping on #3453 before this pull gets too big. |
Is this ready to be merged or should it wait for #3453? |
It's ready to be merged. I have only been adding little improvements, while keeping everything stable. :-) Still have some ideas like colorized help and |
This looks awesome, @epdenouden! Nice work 🙂 |
@rpkamp Thanks! It is nice to hear people enjoy using the stuff I enjoy making. 🍰 If you have any wishes or ideas let me know, I do intend to keep improving the various output formats incrementally. |
While working on the buffered TestDox printer I found the output format really useful for work on the terminal. Adding some color highlighting and removing clutter gives it a completely different look. It's much easier to spot when something needs attention.
Changes
Basic handling of ANSI colors gets its own helper class until we migrate over to a better CLI/console library. Its own test suite gives a quick demo of most features:
TestSuite
by underlining the class name or class@testdox
-annotation@dataprovider
parameter values used in@testdox
are highlighted@testdox
has access to the name of the@dataprovider
-row via$_dataName
@dataprovider
without@testdox
The
CLITestDoxPrinter
has been cleaned up further. It has given me fresh ideas for theTestListener
rewrite and cleaning up the pile of slow end-to-end tests. I'll be creating issues with proposed practical solutions for this. This has been a nice warming up for working on a new implementation for the test result event system.Any remarks or ideas are very welcome as always.