willThrowException() only accepts Exception, not Throwable

[Stadly]

No description provided.

[gmponos]

I need this too.. any progress?

[epdenouden]

Change looks useful. @Stadly can you merge in the latest master, so all tests run? Thx

[codecov]

Codecov Report

Merging #3414 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #3414      +/-   ##
============================================
- Coverage     82.15%   82.09%   -0.07%     
+ Complexity     3580     3530      -50     
============================================
  Files           143      143              
  Lines          9398     9291     -107     
============================================
- Hits           7721     7627      -94     
+ Misses         1677     1664      -13

Impacted Files	Coverage Δ	Complexity Δ
.../Framework/MockObject/Builder/InvocationMocker.php	80.82% <100%> (ø)	24 <1> (ø)	⬇️
src/Framework/Constraint/LogicalXor.php	36.11% <0%> (-58.34%)	14% <0%> (ø)
src/Util/Log/TeamCity.php	52.79% <0%> (-7.9%)	62% <0%> (+8%)
src/Util/TestDox/CliTestDoxPrinter.php	87.34% <0%> (-7.61%)	27% <0%> (-35%)
src/Util/Log/JUnit.php	90% <0%> (-4.45%)	32% <0%> (-3%)
src/Runner/PhptTestCase.php	79.06% <0%> (-1.11%)	79% <0%> (-4%)
src/Runner/TestSuiteSorter.php	99.02% <0%> (-0.98%)	47% <0%> (-7%)
src/Framework/Assert.php	92.13% <0%> (-0.3%)	232% <0%> (-8%)
src/TextUI/TestRunner.php	69.11% <0%> (-0.15%)	287% <0%> (-2%)
src/Util/Configuration.php	97.48% <0%> (-0.02%)	179% <0%> (-1%)
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6d9814...ff7ae75. Read the comment docs.

[codecov]

Codecov Report

Merging #3414 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #3414   +/-   ##
=========================================
  Coverage     82.15%   82.15%           
  Complexity     3580     3580           
=========================================
  Files           143      143           
  Lines          9398     9398           
=========================================
  Hits           7721     7721           
  Misses         1677     1677

Impacted Files	Coverage Δ	Complexity Δ
.../Framework/MockObject/Builder/InvocationMocker.php	80.82% <100%> (ø)	24 <1> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6d9814...ff7ae75. Read the comment docs.

[Stadly]

Done

[epdenouden]

That's quick, thank you!

[epdenouden]

@sebastianbergmann Change looks useful to me, would be nice to merge this, unless you know of something else breaking. The logging and reporting side uses Throwable already, too.

[gmponos]

@epdenouden I am not sure if with the current change other places must change as well...

I mean what about expectedException function.. this must also allow Throwables..

Haven't checked the code though... so it might already be fine...

[gmponos]

The logging and reporting side uses Throwable already, too

@epdenouden ah.. when you were saying reporting you were referring to things like expectedException?

[epdenouden]

@gmponos That is a good point. I have not done an in-depth code review of the surrounding code. 🤐 Internally I think we can upgrade it all to Throwable anyway. Only exception would be strict checks for Exception, I think.

With the reporting I only meant the method signatures in the printers and listeners. Lots of stuff going to be refactored there and Throwable is the new fashionable thing. :)

[gmponos]

On the other hand you could accept current PR and see the other places later.. your call..

[epdenouden]

Yes. The built-in collection of tests should keep us relatively safe 😂

[sebastianbergmann]

Merged manually, thanks.