Fix reverse order test failures #3402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test makes sure that the configuration file cannot override system environment settings by using putenv(). This is not restored by the backupGlobals system, causing another configuration test to fail. Obviously this could have been fixed by using a variable name other than 'foo', but I'll like having this here as a reminder of the dependency on putenv/getenv.
Codecov Report
@@ Coverage Diff @@
## master #3402 +/- ##
=========================================
Coverage 83.05% 83.05%
Complexity 3570 3570
=========================================
Files 143 143
Lines 9503 9503
=========================================
Hits 7893 7893
Misses 1610 1610Continue to review full report at Codecov.
|
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listening to the tests in reverse revealed evil hidden messages 馃