Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency: testdox for method that is written in snake-case now starts with uppercase #3105

Merged
merged 1 commit into from Apr 25, 2018

Conversation

dennie170
Copy link

Currently testdox prints the test names with a lowercase letter when you write them like this: public function test_this_method(), whereas it would start with an uppercase letter if you named your method like this: public function testThisMethod(). This commit fixes that.

@codecov-io
Copy link

codecov-io commented Apr 25, 2018

Codecov Report

Merging #3105 into 7.1 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##               7.1   #3105      +/-   ##
==========================================
+ Coverage     80.9%   80.9%   +<.01%     
- Complexity    2884    2885       +1     
==========================================
  Files          108     108              
  Lines         7550    7552       +2     
==========================================
+ Hits          6108    6110       +2     
  Misses        1442    1442
Impacted Files Coverage Δ Complexity Δ
src/Util/TestDox/NamePrettifier.php 97.61% <100%> (+0.11%) 22 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c5a07...be15650. Read the comment docs.

@sebastianbergmann sebastianbergmann merged commit 7cd0cdb into sebastianbergmann:7.1 Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants