Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow returning null result #3087

Conversation

greg0ire
Copy link
Contributor

@greg0ire greg0ire commented Apr 9, 2018

This can and does happen with Symfony's phpunit-bridge listener. Apart
for that, this property is not guaranteed to be not null (there is a
setter and no constructor requirement), so the return type hint should
reflect that.
See symfony/symfony#26861

This can and does happen with Symfony's phpunit-bridge listener. Apart
for that, this property is not guaranteed to be not null (there is a
setter and no constructor requirement), so the return type hint should
reflect that.
See symfony/symfony#26861
@codecov-io
Copy link

codecov-io commented Apr 9, 2018

Codecov Report

Merging #3087 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3087      +/-   ##
============================================
+ Coverage     80.89%   80.92%   +0.02%     
- Complexity     2897     2898       +1     
============================================
  Files           108      108              
  Lines          7591     7591              
============================================
+ Hits           6141     6143       +2     
+ Misses         1450     1448       -2
Impacted Files Coverage Δ Complexity Δ
src/Framework/TestCase.php 67.37% <100%> (+0.24%) 305 <2> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 114a763...a3c8c5f. Read the comment docs.

@greg0ire
Copy link
Contributor Author

greg0ire commented Apr 9, 2018

@sebastianbergmann
Copy link
Owner

Merged manually, thanks.

@greg0ire greg0ire deleted the allow_getting_null_result_object branch April 10, 2018 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants