Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@requires should support != for every type #5607

Open
mvorisek opened this issue Dec 10, 2023 · 2 comments
Open

@requires should support != for every type #5607

mvorisek opened this issue Dec 10, 2023 · 2 comments
Labels
type/enhancement A new idea that should be implemented

Comments

@mvorisek
Copy link
Contributor

@requires OSFAMILY != Windows should be supported.

Currently the docs say the operators are supported for PHP, PHPUnit and extension version constraints only.

I belive all operators should be supported and <, >, >=, <= should emit a warning if the left/right side of the expression is non-version string.
@mvorisek mvorisek added the type/enhancement A new idea that should be implemented label Dec 10, 2023
@sebastianbergmann
Copy link
Owner

Annotations will not be changed. In fact, they will be deprecated in PHPUnit 11 and removed in PHPUnit 12.

@epdenouden
Copy link
Contributor

Should also work for the new attributes, I am assuming? Couldn't find it in the manual whether != is supported or not.

If it should be supported but currently isn't, might be a nice small project for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement A new idea that should be implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sebastianbergmann @mvorisek @epdenouden