Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing a library against a runtime without mbstring is not longer possible in 8.5.18 and newer #4755

Closed
stof opened this issue Aug 11, 2021 · 2 comments
Labels
type/enhancement A new idea that should be implemented

Comments

@stof
Copy link
Contributor

stof commented Aug 11, 2021

bf56acb introduced an early check aborting if mbstring is missing (alongside other extensions for which I don't have issues as they are necessary for PHPUnit to work).
However, the mbstring dependency of PHPUnit is a bit special: it is only necessary for the --testdox output. Using a different output (the default one for instance) does not need it.

We were relying on that in the scssphp project to run a CI job with mbstring disabled, to ensure that our library was still compatible with runtimes that don't have mbstring (using --ignore-platform-req=mbstring in Composer to skip this requirement), which was working fine on older versions.

Would it be possible to change the mbstring to happen only if the testdox output is used instead ? The original issue #4720 was only requesting a check in that case too.

@stof stof added the type/enhancement A new idea that should be implemented label Aug 11, 2021
@sebastianbergmann
Copy link
Owner

However, the mbstring dependency of PHPUnit is a bit special: it is only necessary for the --testdox output. Using a different output (the default one for instance) does not need it.

That is not correct:

To me, the mbstring extension is not optional.

@stof
Copy link
Contributor Author

stof commented Aug 11, 2021

hmm, indeed, I forgot that our testsuite also does not use the StringContains constraint (and that we use UTF-8 for our XML config file so we don't need the encoding conversion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A new idea that should be implemented
Projects
None yet
Development

No branches or pull requests

2 participants