Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit code with no tests changed in bugfix release 8.5.7 (probably also 9.x) #4312

Closed
dominikzogg opened this issue Jun 22, 2020 · 4 comments
Closed

Exit code with no tests changed in bugfix release 8.5.7 (probably also 9.x) #4312

dominikzogg opened this issue Jun 22, 2020 · 4 comments
Assignees
@sebastianbergmann
Labels
feature/test-runner CLI test runner type/bug Something is broken

Comments

@dominikzogg
Copy link

dominikzogg commented Jun 22, 2020 •
edited

Q A
PHPUnit version 8.5.7
PHP version 7.2.15, 7.3.19 , 7.4.7
Installation Method Composer

Summary

Since PHPUnit 8.5.7 its a problem it there are no tests and the exit code is 1. Before that the return value was 0.
All my newer libraries have a testsuite for unit tests and one for integration test. Not every library has integration tests. Until 8.5.6 this wasn't an issue.

Current behavior

No tests => exit code: 1

How to reproduce

setup any project with a testsuite without tests

https://travis-ci.org/github/chubbyphp/chubbyphp-container/builds/700689350

https://travis-ci.org/github/chubbyphp/chubbyphp-container/jobs/700689357
https://travis-ci.org/github/chubbyphp/chubbyphp-container/jobs/700689360
https://travis-ci.org/github/chubbyphp/chubbyphp-container/jobs/700689363

Expected behavior

No tests => exit code: 0
@dominikzogg dominikzogg added the type/bug Something is broken label Jun 22, 2020
@sebastianbergmann
Copy link
Owner

It was a bug that PHPUnit exited with 0 when it should have exited with 1.

@sebastianbergmann sebastianbergmann removed the type/bug Something is broken label Jun 22, 2020
@sebastianbergmann
Copy link
Owner

See #4299 (comment)

@sebastianbergmann sebastianbergmann self-assigned this Jun 22, 2020
@sebastianbergmann sebastianbergmann added feature/test-runner CLI test runner type/bug Something is broken labels Jun 22, 2020
@dominikzogg
Copy link
Author

@sebastianbergmann thanks

@dominikzogg
Copy link
Author

@sebastianbergmann thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianbergmann sebastianbergmann

Labels
feature/test-runner CLI test runner type/bug Something is broken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastianbergmann @dominikzogg