Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not suggest refactoring to something that is also deprecated #4017

Merged
merged 1 commit into from Jan 17, 2020
Merged

Do not suggest refactoring to something that is also deprecated #4017

merged 1 commit into from Jan 17, 2020

Conversation

GrahamCampbell
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #4017 into 8.5 will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##                8.5    #4017      +/-   ##
============================================
- Coverage     84.91%   84.86%   -0.05%     
  Complexity     3921     3921              
============================================
  Files           153      153              
  Lines         10093    10093              
============================================
- Hits           8570     8565       -5     
- Misses         1523     1528       +5
Impacted Files Coverage Δ Complexity Δ
src/Framework/TestCase.php 81.81% <0%> (ø) 339 <0> (ø) ⬇️
src/Runner/Version.php 64.7% <0%> (-5.89%) 8% <0%> (ø)
src/Util/PHP/AbstractPhpProcess.php 71.97% <0%> (-2.55%) 43% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b1f920...828f484. Read the comment docs.

@sebastianbergmann sebastianbergmann changed the title [8.5] Don't suggest refactoring to something that's also deprecated Do not suggest refactoring to something that is also deprecated Jan 17, 2020
@sebastianbergmann sebastianbergmann self-assigned this Jan 17, 2020
@sebastianbergmann sebastianbergmann added the type/enhancement A new idea that should be implemented label Jan 17, 2020
@sebastianbergmann sebastianbergmann merged commit cae69be into sebastianbergmann:8.5 Jan 17, 2020
@sebastianbergmann sebastianbergmann added type/bug Something is broken and removed type/enhancement A new idea that should be implemented labels Jan 17, 2020
@GrahamCampbell GrahamCampbell deleted the patch-1 branch January 17, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants