Trailing slash in XdebugFilterScriptGenerator.php breaks coverage in windows

[shivammathur]

Q	A
PHPUnit version	8.3
PHP version	7.2.10
Installation Method	Composer

Trailing slash after %s in XdebugFilterScriptGenerator results in 0% coverage on windows as it has backslash as separator.

phpunit/src/Util/XdebugFilterScriptGenerator.php

Line 59 in c2fa2fc

$files[] = \sprintf('%s/', $path);

Current code on windows generates this xdebug-filter.php

<?php declare(strict_types=1);
if (!\function_exists('xdebug_set_filter')) {
    return;
}

\xdebug_set_filter(
    \XDEBUG_FILTER_CODE_COVERAGE,
    \XDEBUG_PATH_WHITELIST,
    [
        'C:\path\to\dir/'
    ]
);

Correct xdebug-filter.php should be

<?php declare(strict_types=1);
if (!\function_exists('xdebug_set_filter')) {
    return;
}

\xdebug_set_filter(
    \XDEBUG_FILTER_CODE_COVERAGE,
    \XDEBUG_PATH_WHITELIST,
    [
        'C:\path\to\dir\\'
    ]
);

So constant DIRECTORY_SEPARATOR can be used with proper escaping.

[shivammathur]

Hi @sebastianbergmann I will submit a PR in a bit.

[shivammathur]

@sebastianbergmann Your patch gives a syntax error. See #3835 (comment)