Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a fatal TypeError when an incorrect file path is given as second argument #3674

Conversation

LANGERGabrielle
Copy link
Contributor

The following command will now return a helpful error message, instead of a TypeError:
phpunit tests /wrong/path/to/file.php

@LANGERGabrielle LANGERGabrielle force-pushed the 7.5-error-on-incorrect-test-file branch from b5a087b to c9fe4f0 Compare April 30, 2019 23:07
@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #3674 into 7.5 will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                7.5    #3674      +/-   ##
============================================
+ Coverage     83.43%   83.45%   +0.01%     
- Complexity     3642     3643       +1     
============================================
  Files           143      143              
  Lines          9692     9698       +6     
============================================
+ Hits           8087     8093       +6     
  Misses         1605     1605
Impacted Files Coverage Δ Complexity Δ
src/TextUI/Command.php 72.08% <100%> (+0.28%) 207 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f66fc1...c9fe4f0. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #3674 into 7.5 will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                7.5    #3674      +/-   ##
============================================
+ Coverage     83.43%   83.45%   +0.01%     
- Complexity     3642     3643       +1     
============================================
  Files           143      143              
  Lines          9692     9698       +6     
============================================
+ Hits           8087     8093       +6     
  Misses         1605     1605
Impacted Files Coverage Δ Complexity Δ
src/TextUI/Command.php 72.08% <100%> (+0.28%) 207 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f66fc1...c9fe4f0. Read the comment docs.

@sebastianbergmann sebastianbergmann merged commit 1973180 into sebastianbergmann:7.5 May 6, 2019
@sebastianbergmann sebastianbergmann added the type/bug Something is broken label May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants