Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure in end-to-end regression test with PHP 7.3 #3638

Closed
oliverklee opened this issue Apr 27, 2019 · 7 comments
Closed

Test failure in end-to-end regression test with PHP 7.3 #3638

oliverklee opened this issue Apr 27, 2019 · 7 comments
Labels
event/code-sprint/2019-04 PHPUnit Code Sprint: April 2019 event/code-sprint/2019-09 PHPUnit Code Sprint: September 2019

Comments

@oliverklee
Copy link
Sponsor Contributor

Q A
PHPUnit version master 68e2fb1
PHP version 7.3.1
Installation Method Git master from GitHub
1) /Users/klee/src/php/phpunit/tests/end-to-end/regression/GitHub/2591-separate-function-no-preserve-no-bootstrap-php73.phpt
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 PHPUnit 8.2-g68e2fb11f by Sebastian Bergmann and contributors.

-EE                                                                  2 / 2 (100%)
+..                                                                  2 / 2 (100%)

 Time: 193 ms, Memory: 6.00 MB

-There were 2 errors:
-
-1) Issue2591_SeparateFunctionNoPreserveTest::testChangedGlobalString
-PHPUnit\Framework\Exception: %sUncaught Error%sin %s
-%a
-2) Issue2591_SeparateFunctionNoPreserveTest::testGlobalString
-PHPUnit\Framework\Exception: %sUncaught Error%sin %s
-%a
-ERRORS!
-Tests: 2, Assertions: 0, Errors: 2.
+OK (2 tests, 0 assertions)

/Users/klee/src/php/phpunit/tests/end-to-end/regression/GitHub/2591-separate-function-no-preserve-no-bootstrap-php73.phpt:23
/Users/klee/src/php/phpunit/src/Framework/TestSuite.php:547
/Users/klee/src/php/phpunit/src/Framework/TestSuite.php:547
/Users/klee/src/php/phpunit/src/TextUI/TestRunner.php:602
/Users/klee/src/php/phpunit/src/TextUI/Command.php:207
/Users/klee/src/php/phpunit/src/TextUI/Command.php:163
@oliverklee
Copy link
Sponsor Contributor Author

This is with the PHP 7.3.1 provided by MAMP on Mac OS.

@oliverklee
Copy link
Sponsor Contributor Author

oliverklee commented Apr 27, 2019

I get the same result with the MAMP PHP 7.2.14 and 7.3.3.

@oliverklee
Copy link
Sponsor Contributor Author

This is how manuall run what is tested by the end-to-end test:

./phpunit --no-configuration --bootstrap tests/end-to-end/regression/GitHub/2591/bootstrapNoBootstrap.php tests/end-to-end/regression/GitHub/2591/SeparateFunctionNoPreserveTest.php

This is supposed to fail with 2 errors.

@oliverklee
Copy link
Sponsor Contributor Author

Educated guess as of the history of #2591: This might be causes by certain settings in my php.ini.

@sebastianbergmann
Copy link
Owner

If that is the case then we may need to pass (more) INI settings to the child process. This was recently done in #3506.

@sebastianbergmann sebastianbergmann added the event/code-sprint/2019-04 PHPUnit Code Sprint: April 2019 label Apr 28, 2019
@oliverklee
Copy link
Sponsor Contributor Author

oliverklee commented Apr 29, 2019

This is the php.ini for PHP 7.3.3 on my system where the problem occurs:
php7.3.3.ini

@stale stale bot added stale and removed stale labels Jun 28, 2019
Repository owner deleted a comment from stale bot Jul 2, 2019
Repository owner deleted a comment from oliverklee Jul 2, 2019
Repository owner deleted a comment from epdenouden Jul 2, 2019
@oliverklee
Copy link
Sponsor Contributor Author

The tests now work fine for me with the latest PHPUnit master, 8.3 and 7.5 and the latest MAMP. So this issue can be closed.

@sebastianbergmann sebastianbergmann added the event/code-sprint/2019-09 PHPUnit Code Sprint: September 2019 label Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event/code-sprint/2019-04 PHPUnit Code Sprint: April 2019 event/code-sprint/2019-09 PHPUnit Code Sprint: September 2019
Projects
None yet
Development

No branches or pull requests

2 participants