Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate assertContains() and assertNotContains() #3425

Closed
sebastianbergmann opened this issue Nov 29, 2018 · 0 comments
Closed

Deprecate assertContains() and assertNotContains() #3425

sebastianbergmann opened this issue Nov 29, 2018 · 0 comments
Assignees
@sebastianbergmann
Milestone
PHPUnit 8.0

Comments

@sebastianbergmann
Copy link
Owner

See #3422 for migration path.
@sebastianbergmann sebastianbergmann added this to the PHPUnit 8.0 milestone Nov 29, 2018
@sebastianbergmann sebastianbergmann self-assigned this Nov 29, 2018
@sebastianbergmann sebastianbergmann changed the title Deprecate assertContains() and assertNotContains() Deprecate assertContains() and assertNotContains() for string haystacks Nov 29, 2018
@sebastianbergmann sebastianbergmann changed the title Deprecate assertContains() and assertNotContains() for string haystacks Deprecate assertContains() and assertNotContains() Nov 29, 2018
@sebastianbergmann sebastianbergmann mentioned this issue Feb 5, 2019
Closed
@peter279k peter279k mentioned this issue Mar 25, 2019
Open
3 tasks
@RVxLab RVxLab mentioned this issue Sep 8, 2019
Closed
@wkania wkania mentioned this issue Apr 8, 2020
Merged
javiereguiluz added a commit to symfony/symfony-docs that referenced this issue Apr 9, 2020
@javiereguiluz
minor #13511 [Testing] Change deprecated assertContains to assertStri…
0147fe6 
…ngContainsString (Wojciech Kania)

This PR was merged into the 5.0 branch.

Discussion
----------

[Testing] Change deprecated assertContains to assertStringContainsString

Symfony 5 requires PHP 7.2. PHPUnit Bridge for this version by default use [PHPUnit 8.3](https://symfony.com/doc/current/components/phpunit_bridge.html#modified-phpunit-script).
The assertContains is [deprecated](sebastianbergmann/phpunit#3425) and in PHPUnit 9 throws an error.

Commits
-------

e4d8c27 [Testing] Change deprecated assertContains to assertStringContainsString
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianbergmann sebastianbergmann

Labels
None yet
Projects
None yet
Milestone
PHPUnit 8.0
Development

No branches or pull requests
1 participant
@sebastianbergmann