Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove assertInternalType() and assertNotInternalType() #3370

Closed
sebastianbergmann opened this issue Oct 24, 2018 · 0 comments
Closed

Remove assertInternalType() and assertNotInternalType() #3370

sebastianbergmann opened this issue Oct 24, 2018 · 0 comments
Assignees
@sebastianbergmann
Labels
type/backward-compatibility Something will be/is intentionally broken
Milestone
PHPUnit 9.0

Comments

@sebastianbergmann
Copy link
Owner

See #3368 for migration path.
@sebastianbergmann sebastianbergmann added feature-removal type/backward-compatibility Something will be/is intentionally broken labels Oct 24, 2018
@sebastianbergmann sebastianbergmann added this to the PHPUnit 9.0 milestone Oct 24, 2018
@sebastianbergmann sebastianbergmann self-assigned this Oct 24, 2018
@sebastianbergmann sebastianbergmann mentioned this issue Mar 3, 2019
Closed
@stale stale bot added the stale label Jul 2, 2019
Repository owner deleted a comment from stale bot Jul 2, 2019
sj-i added a commit to sj-i/php-database that referenced this issue Jan 27, 2021
@sj-i
support PHP8, currently not backward compatible with earlier PHP vers…
9341757 
…ions.

# method signatures
- sync signatures of PDO methods with PHP8
	- PHP8 has named parameters, so also names of parameters should be compatible with parent
- change Exception thrown to sync with PHP8

# phpunit
- at() was deprecated as of phpunit9.3, so added a polyfill to avoid warnings for now. sebastianbergmann/phpunit#4297
- assertInternalType() was removed in phpunit9. sebastianbergmann/phpunit#3370
- setUp() and tearDown() have return type declaration of void as of phpunit8. sebastianbergmann/phpunit#3288
- @ExpectedException was removed in phpunit9. sebastianbergmann/phpunit#3333
@sj-i sj-i mentioned this issue Jan 27, 2021
Merged
sj-i added a commit to sj-i/php-database that referenced this issue Jan 27, 2021
@sj-i
support PHP8, currently not backward compatible with earlier PHP vers…
dc0e41b 
…ions.

# method signatures
- sync signatures of PDO methods with PHP8
	- PHP8 has named parameters, so also names of parameters should be compatible with parent
- change Exception thrown to sync with PHP8

# phpunit
- at() was deprecated as of phpunit9.3, so added a polyfill to avoid warnings for now. sebastianbergmann/phpunit#4297
- assertInternalType() was removed in phpunit9. sebastianbergmann/phpunit#3370
- setUp() and tearDown() have return type declaration of void as of phpunit8. sebastianbergmann/phpunit#3288
- @ExpectedException was removed in phpunit9. sebastianbergmann/phpunit#3333
sj-i added a commit to sj-i/php-database that referenced this issue Jan 27, 2021
@sj-i
support PHP8, currently not backward compatible with earlier PHP vers…
e774916 
…ions.

# method signatures
- sync signatures of PDO methods with PHP8
	- PHP8 has named parameters, so also names of parameters should be compatible with parent
- change Exception thrown to sync with PHP8

# phpunit
- at() was deprecated as of phpunit9.3, so added a polyfill to avoid warnings for now. sebastianbergmann/phpunit#4297
- assertInternalType() was removed in phpunit9. sebastianbergmann/phpunit#3370
- setUp() and tearDown() have return type declaration of void as of phpunit8. sebastianbergmann/phpunit#3288
- @ExpectedException was removed in phpunit9. sebastianbergmann/phpunit#3333
@jlherren jlherren mentioned this issue Apr 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianbergmann sebastianbergmann

Labels
type/backward-compatibility Something will be/is intentionally broken
Projects
None yet
Milestone
PHPUnit 9.0
Development

No branches or pull requests
1 participant
@sebastianbergmann