Skip to content

Case sensitivity for --filter #3181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stof opened this issue Jun 22, 2018 · 3 comments · Fixed by elecena/nano#2
Closed

Case sensitivity for --filter #3181

stof opened this issue Jun 22, 2018 · 3 comments · Fixed by elecena/nano#2

Comments

@stof
Copy link
Contributor

stof commented Jun 22, 2018

Q A
PHPUnit version 7.2.4
PHP version 7.2.6
Installation Method Composer

Currently, the matching of tests for --filter is case sensitive. It happens a lot to me that no tests are running at all, due to writing the filter all in lowercase rather than putting capital letters matching the test name.
Would it make sense to perform a case-insensitive match instead ?
@sebastianbergmann
Copy link
Owner

Maybe. You can also pass a regular expression that works in a case insensitive way.

@stale
Copy link

stale bot commented Aug 21, 2018

This issue has been automatically marked as stale because it has not had activity within the last 60 days. It will be closed after 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 21, 2018
@stof
Copy link
Contributor Author

stof commented Aug 21, 2018

passing a regular expression is more complex. I still think that being case insensitive for the simple matching would make more sense.

@stale stale bot removed the stale label Aug 21, 2018
sebastianfeldmann pushed a commit to sebastianfeldmann/phpunit that referenced this issue Sep 7, 2018
Make --filter case insensitive - issue sebastianbergmann#3181
0d16908
sebastianfeldmann pushed a commit to sebastianfeldmann/phpunit that referenced this issue Sep 7, 2018
Make --filter case insensitive - issue sebastianbergmann#3181
eea8cb6
sebastianfeldmann pushed a commit to sebastianfeldmann/phpunit that referenced this issue Sep 7, 2018
Make --filter case insensitive - issue sebastianbergmann#3181
7047082
sebastianfeldmann pushed a commit to sebastianfeldmann/phpunit that referenced this issue Sep 7, 2018
Make --filter case insensitive - issue sebastianbergmann#3181
64276db
sebastianbergmann pushed a commit that referenced this issue Sep 7, 2018
@sebastianbergmann
Make --filter case insensitive - issue #3181

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
7c39e56
@dependabot dependabot bot mentioned this issue Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump phpunit/phpunit from 6.5.0 to 6.5.14 elecena/nano
2 participants
@sebastianbergmann @stof