Strict mocking

[index0h]

Q	A
PHPUnit version	7.0.2
PHP version	7.2.6
Installation Method	Composer

Hi, by default phpunit mock object allows you to call any methods: mocked and real.
You should declare a lot of "never" expectations in test cases for complete check your code.
When your covered code is changing, for example added new call of depended mock, tests not fail.
This behavior is error source.

Example:

class Dependency
{
    public function first() {}
    public function second() {}
}

class Testable
{
    /** @var Dependency */
    private $dependency;

    public function __construct(Dependency $dependency)
    {
        $this->dependency = $dependency;
    }

    public function run(bool $runFirst): void
    {
        if ($runFirst) {
            $this->dependency->first();
        } else { // Added just now
            $this->dependency->second();
        }
    }
}

class TestableTest extends TestCase
{
    // Developer forgot to mock Dependency::second method, but test not fail
    public function testRunPositive(): void
    {
        /** @var Dependency|MockObject $dependency */
        $dependency = $this->createMock(Dependency::class);

        $dependency
            ->expects($this->once())
            ->method('first');

        (new Testable($dependency))->run(true);
    }

    // Developer forgot to mock Dependency::second method, but test not fail
    public function testRunNegative(): void
    {
        /** @var Dependency|MockObject $dependency */
        $dependency = $this->createMock(Dependency::class);

        $dependency
            ->expects($this->never())
            ->method('first');

        (new Testable($dependency))->run(false);
    }
}

I'm trying to create constraint, which denies calling not mocked methods.
Is there way to get method name matchers without reflection, or call InvocationMocker::matches without invocation of other constraints?

I also tried to override InvocationMocker and set it to mockObject by reflection but it's dirty hack((

Could you suggest some other way for my case?

[epdenouden]

@index0h Thank you for the bug report! As it relates to dependencies also, I will have a look if it relates to #3092.

[sebastianbergmann]

I agree with @index0h, that there should be an API, for instance createStrictMock() and createStrictStub() (see #3120), that allows creating test doubles that are, by default, closer to what Prophecy does.

[sebastianbergmann]

@epdenouden I do not think that this has anything to do with @depends and/or your recent improvements to how PHPUnit executes tests.

[epdenouden]

@sebastianbergmann Alright, I will continue on the other PR then. Lemme know if anything comes up and I'll take a look tonight

[index0h]

Any news here?

[Chekote]

I'm also curious about the status of this. Has there been any developments?